Uploaded image for project: 'netconf'
  1. netconf
  2. NETCONF-440

rpc-error in keepalive rpc-reply shouldn't bounce the session

    XMLWordPrintable

Details

    • Bug
    • Status: Resolved
    • Resolution: Done
    • None
    • None
    • netconf
    • None
    • Operating System: All
      Platform: All

    • 8832

    Description

      If the keepalive rpc-reply has errors, it means the other end of the session is still available, hence the session shouldn't be bounced.

      Current implementation for keepalive only checks for results but not for errors: https://github.com/opendaylight/netconf/blob/master/netconf/sal-netconf-connector/src/main/java/org/opendaylight/netconf/sal/connect/netconf/sal/KeepaliveSalFacade.java#L207

      Implementation for other rpcs is ok, and doesn't even check the content of the result, assuming that as long as you have a result, the rpc reached the device: https://github.com/opendaylight/netconf/blob/master/netconf/sal-netconf-connector/src/main/java/org/opendaylight/netconf/sal/connect/netconf/sal/KeepaliveSalFacade.java#L228

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            adetalhouet Alexis de Talhouët
            adetalhouet Alexis de Talhouët
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: