Details
-
Task
-
Status: In Progress
-
Medium
-
Resolution: Unresolved
-
None
-
None
Description
A quick grep is showing these users of deprecated API:
./openflowplugin/applications/arbitratorreconciliation/impl/src/main/java/org/opendaylight/openflowplugin/applications/arbitratorreconciliation/impl/ArbitratorReconciliationManagerImpl.java: rpcProviderService.registerRpcImplementation(ArbitratorReconcileService.class, this, Set.of(path)); ./openflowplugin/applications/forwardingrules-manager/src/main/java/org/opendaylight/openflowplugin/applications/frm/impl/DeviceMastership.java: reg = rpcProviderService.registerRpcImplementation(FrmReconciliationService.class, reconcliationService, ./openflowplugin/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/statistics/StatisticsManagerImpl.java: .registerRpcImplementation(StatisticsManagerControlService.class, this); ./openflowplugin/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/OpenFlowPluginProviderImplTest.java: when(rpcProviderRegistry.registerRpcImplementation(eq(StatisticsManagerControlService.class), any())) ./openflowplugin/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/rpc/RpcContextImplTest.java: verify(rpcProviderRegistry, times(1)).registerRpcImplementation(TestRpcService.class, serviceInstance, ./openflowplugin/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/rpc/RpcContextImplTest.java: when(rpcProviderRegistry.registerRpcImplementation(eq(TestRpcService.class), eq(serviceInstance), anySet())) ./openflowplugin/test-provider/src/main/java/org/opendaylight/openflowplugin/test/OpenflowpluginGroupTestServiceProvider.java: setGroupRegistration(rpcRegistry.registerRpcImplementation(SalGroupService.class, this, ImmutableSet.of( ./openflowplugin/test-provider/src/main/java/org/opendaylight/openflowplugin/test/OpenflowpluginMeterTestServiceProvider.java: setMeterRegistration(rpcRegistry.registerRpcImplementation(SalMeterService.class, this, ImmutableSet.of( ./openflowplugin/test-provider/src/main/java/org/opendaylight/openflowplugin/test/OpenflowpluginTableFeaturesTestServiceProvider.java: setTableRegistration(rpcRegistry.registerRpcImplementation(SalTableService.class, this, ImmutableSet.of( ./openflowplugin/test-provider/src/main/java/org/opendaylight/openflowplugin/test/OpenflowpluginTestServiceProvider.java: setFlowRegistration(rpcRegistry.registerRpcImplementation(SalFlowService.class, this, ImmutableSet.of(
Convert them to new-style yang.binding.Rpc-based implementations.
Attachments
Issue Links
- blocks
-
MDSAL-772 Remove RpcService
-
- Resolved
-
Gerrit Reviews
| # | Subject | Branch | Project | Status | CR | V |
|---|---|---|---|---|---|---|
| 107983,3 | Remove dependency on RpcService for openflow-protocol | master | openflowplugin | Status: NEW | 0 | +1 |
| 108097,14 | WIP: Do not use RpcService in lldp-speaker | master | openflowplugin | Status: NEW | 0 | -1 |
| 108101,13 | WIP: Do not use RpcService in arbitratorreconciliation-impl | master | openflowplugin | Status: NEW | 0 | -1 |
| 108223,8 | Do not use RpcService in SalRoleServiceImpl class | master | openflowplugin | Status: NEW | 0 | -1 |
| 108224,8 | Do not use RpcService in OpendaylightFlowTableStatisticsServiceImpl | master | openflowplugin | Status: NEW | 0 | -1 |
| 108225,8 | Do not use RpcService in OpendaylightDirectStatisticsServiceImpl | master | openflowplugin | Status: NEW | 0 | -1 |
| 108226,8 | Do not use RpcService in OpendaylightGroupStatisticsServiceImpl | master | openflowplugin | Status: NEW | 0 | -1 |
| 108227,8 | Do not use RpcService in OpendaylightMeterStatisticsServiceImpl | master | openflowplugin | Status: NEW | 0 | -1 |
| 108228,8 | Do not use RpcService in OpendaylightPortStatisticsServiceImpl | master | openflowplugin | Status: NEW | 0 | -1 |
| 108229,8 | Do not use RpcService in OpendaylightQueueStatisticsServiceImpl | master | openflowplugin | Status: NEW | 0 | -1 |
| 108230,12 | Do not use RpcService in SalTableServiceImpl | master | openflowplugin | Status: NEW | 0 | -1 |
| 108231,13 | Do not use RpcService in SalBundleServiceImpl | master | openflowplugin | Status: NEW | 0 | -1 |
| 108232,12 | Do not use RpcService in SalExperimenterMpMessageServiceImpl | master | openflowplugin | Status: NEW | 0 | -1 |
| 108233,12 | Do not use RpcService in OpendaylightFlowStatisticsServiceImpl | master | openflowplugin | Status: NEW | 0 | -1 |
| 108235,12 | WIP: Do not use RpcService in new of-switch-config-pusher | master | openflowplugin | Status: NEW | 0 | -1 |
| 108236,12 | WIP: Do not use RpcService in table-miss-enforcer | master | openflowplugin | Status: NEW | 0 | -1 |
| 108237,12 | WIP: Do not use RpcService in forwardingrules-manager | master | openflowplugin | Status: NEW | 0 | -1 |
| 108238,12 | WIP: Do not use RpcService in southbound-cli | master | openflowplugin | Status: NEW | 0 | -1 |
| 108240,12 | WIP: Do not use RpcService in sample-bundles | master | openflowplugin | Status: NEW | 0 | -1 |
| 108242,12 | WIP: Do not use RpcService in test-extension module | master | openflowplugin | Status: NEW | 0 | -1 |
| 108243,12 | WIP: Do not use RpcService in test-common and drop-test-karaf | master | openflowplugin | Status: NEW | 0 | -1 |
| 110182,3 | Convert arbitratorreconciliation to OSGi DS | master | openflowplugin | Status: NEW | -1 | -1 |
| 107946,1 | WIP: Do not use RpcService in OPENFLOW components | master | openflowplugin | Status: ABANDONED | 0 | -1 |
| 108000,1 | WIP: Do not use RpcService in applications-aggregator components | master | openflowplugin | Status: ABANDONED | 0 | -1 |
| 108096,8 | Do not use RpcService in test-provider module | master | openflowplugin | Status: MERGED | +2 | +1 |
| 108100,16 | Do not use RpcService in bulk-o-matic | master | openflowplugin | Status: MERGED | +2 | +1 |
| 108215,5 | Adapt RpcContext to eliminate RpcService | master | openflowplugin | Status: ABANDONED | 0 | +1 |
| 108216,8 | Migrate StatisticsManagerImpl | master | openflowplugin | Status: MERGED | +2 | +1 |
| 108217,7 | Do not use RpcService in FlowCapableTransactionServiceImpl | master | openflowplugin | Status: ABANDONED | 0 | -1 |
| 108218,6 | Do not use RpcService in SalAsyncConfigServiceImpl class | master | openflowplugin | Status: ABANDONED | 0 | -1 |
| 108219,7 | Do not use RpcService in SalEchoServiceImpl class | master | openflowplugin | Status: ABANDONED | 0 | -1 |
| 108220,6 | Do not use RpcService in NodeConfigServiceImpl class | master | openflowplugin | Status: ABANDONED | 0 | -1 |
| 108221,6 | Do not use RpcService in PacketProcessingServiceImpl class | master | openflowplugin | Status: ABANDONED | 0 | -1 |
| 108222,8 | Do not use RpcService in SalPortServiceImpl class | master | openflowplugin | Status: ABANDONED | 0 | -1 |
| 108234,18 | Do not use RpcService in forwardingrules-sync | master | openflowplugin | Status: MERGED | +2 | +1 |
| 108239,15 | Do not use RpcService in learning-switch | master | openflowplugin | Status: MERGED | +2 | +1 |
| 108241,12 | WIP: Do not use RpcService in sample-consumer | master | openflowplugin | Status: ABANDONED | 0 | -1 |
| 108244,13 | Do not use RpcService in RpcContext | master | openflowplugin | Status: ABANDONED | 0 | +1 |
| 110147,3 | Refactor RpcContext | master | openflowplugin | Status: MERGED | +2 | +1 |
| 110150,1 | Remove unused routedRpcRegistration | master | openflowplugin | Status: MERGED | +2 | +1 |
| 110152,11 | Decompose RPC implementation classes | master | openflowplugin | Status: MERGED | +2 | +1 |