Uploaded image for project: 'releng'
  1. releng
  2. RELENG-36

Distribution-check should be run on trivial rebases and no-code changes

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • None
    • unspecified
    • Jenkins Job Builder
    • None
    • Operating System: All
      Platform: All

    • 6926

      ... because distribution-check allows you to spot whenever you're breaking a dependency or something of the sort.

      The reason I'm opening this bug is because I faced the following:

      • PatchXYZ in Genius removes an artifact
      • Netvirt is actually using the artifact the Genius patch PatchXYZ wants to remove
      • PatchXYZ will fail to build because distribution-check will complain of a missing dependency (obviously the one build PatchXYZ removes)
      • Update the commit message --> only the verify job gets triggered, and jenkins will successfully verified. But distribution-check will not run, thus the patch will get verified, although it should have failed.

      Merging such a patch would break autorelease. I think to avoid this, we should always run distribution-check.

      See https://git.opendaylight.org/gerrit/#/c/46689/ for reference.

            vrpolak Vratko Polak
            adetalhouet Alexis de Talhouƫt
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: