Uploaded image for project: 'yangtools'
  1. yangtools
  2. YANGTOOLS-947

Split out ModificationApplyOperation.verifyStructure() into two methods

    XMLWordPrintable

Details

    • Improvement
    • Status: Resolved
    • Medium
    • Resolution: Done
    • None
    • 3.0.0, 2.0.17, 2.1.9
    • None
    • None

    Description

      This method is heavily overloaded, with a total of 8 implementations, most of which are doing the same thing. Furthermore the original call sites use a static true/false flag, which is indicative the two calls really are separate, with verifyChildren=true including the case of verifyChildren=false.

      Further confusion arises from recursivelyVerifyStructure(), which seems to be an unconditional variant of verifyStructure(verifyChildren=true).

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            rovarga Robert Varga
            rovarga Robert Varga
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: