Uploaded image for project: 'yangtools'
  1. yangtools
  2. YANGTOOLS-1072

Refactor BitsTypeDefinition.Bit and its implementations

    XMLWordPrintable

Details

    • Improvement
    • Status: Resolved
    • Medium
    • Resolution: Done
    • None
    • 5.0.0
    • parser
    • None

    Description

      Bit as such is not a SchemaNode, hence it should derive only from DocumentedNode.WithStatus.

      Furthermore BitStatement/BitEffectiveStatement should not be using QName as their argument, only the string (which should be validated to conform to QName localName rules, but it's still a string).

      Finally the actual implementation is wrong, as we are translating BitEffectiveStatements into BitImpl, which is a bit wrong - as the statement world does not match the type world. This should be fixed by BitEffectiveStatement implementing Bit - and its buildEffective() method needs to create implicit Position statements as appropriate.

      Attachments

        Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

              rovarga Robert Varga
              rovarga Robert Varga
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: